Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

buildRustPackage: support cross-compilation to x86_64-pc-mingw32 #66613

Merged
merged 3 commits into from Aug 15, 2019
Merged

buildRustPackage: support cross-compilation to x86_64-pc-mingw32 #66613

merged 3 commits into from Aug 15, 2019

Conversation

lukateras
Copy link
Member

@lukateras lukateras commented Aug 14, 2019

Motivation for this change

Allows to build Rust packages on Windows. Intended usage scenario is:

let
  nixpkgs-mozilla = import (fetchTarball {
    url = "https://github.com/mozilla/nixpkgs-mozilla/archive/ac8e9d7bbda8fb5e45cae20c5b7e44c52da3ac0c.tar.gz";
    sha256 = "1irlkqc0jdkxdfznq7r52ycnf0kcvvrz416qc7346xhmilrx2gy6";
  });
in

with import <nixpkgs> { overlays = [ nixpkgs-mozilla ]; };

let
  rustChannel = rustChannelOfTargets "nightly" "2019-07-14" [ "x86_64-pc-windows-gnu" ];
  rustPlatform = pkgsCross.mingwW64.makeRustPlatform {
    cargo = rustChannel;
    rustc = rustChannel;
  };
in

rustPlatform.buildRustPackage {
  name = "example";
  src = lib.cleanSource ./.;

  preConfigure = ''
    export HOME=$(mktemp -d)
  '';

  cargoSha256 = "0000000000000000000000000000000000000000000000000000";
}
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @Ericson2314 @matthewbauer

@lukateras
Copy link
Member Author

(cc @Mic92)

homepage = "https://sourceware.org/pthreads-win32";
license = licenses.lgpl21Plus;
maintainers = with maintainers; [ yegortimoshenko ];
platforms = platforms.windows;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CC @angerman was this all broken?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It probably was, nix-build '<nixpkgs>' -A pkgsCross.mingwW64.windows.pthreads --no-out-link fails on No rule to make target 'w32api.h.in', needed by 'w32api.h' as of recent master.

@Ericson2314 Ericson2314 merged commit d13a1bc into NixOS:master Aug 15, 2019
@lukateras
Copy link
Member Author

@Ericson2314 <3

@lukateras lukateras deleted the 201908/rust-win32-cross branch August 15, 2019 14:10
@dermetfan dermetfan mentioned this pull request Aug 20, 2021
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants