efivar: patch build system for reproducibility #66548
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@GrahamcOfBorg build efivar |
grahamc
reviewed
Aug 13, 2019
| patches = [ | ||
| (fetchurl { | ||
| name = "r13y.patch"; | ||
| url = "https://patch-diff.githubusercontent.com/raw/rhboot/efivar/pull/133.patch"; |
There was a problem hiding this comment.
Great work! Nice to get r13y another step forward :D
Two notes (for both @delroth and @mmahut):
- generally we should use fetchpatch over fetchurl for patches, as it makes the patches a bit more stable
- these pull request .patch URLs are quite unstable. As the PR branch changes, or the branch it is merged in to changes, this patch will change contents and the hash will become invalid. In this case fetching the commit's patch directly (https://github.com/delroth/efivar/commit/b81e2f7d72d79b941f71962819606b802e6e835c.patch) would be better.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Make efivar build reproducible. The patch has been submitted upstream.
nix-build --check -A efivarnow passes.Things done
sandboxinnix.confon non-NixOS)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)Notify maintainers
cc @grahamc (r13y)