Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos-enter: add --silent to suppress activation script output #66588

Merged
merged 1 commit into from Aug 15, 2019

Conversation

lschuermann
Copy link
Member

Motivation for this change

Activation script output like setting up /etc... (multiple times) might confuse users when they are prompted to enter a password. This adds an option to suppress the activation script output for such occasions.

If #34058 is merged, messages such as setting up /etc... would otherwise be prompted for every password attempt.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @mmahut

Also, fix a few shellcheck errors.
@mmahut
Copy link
Member

mmahut commented Aug 13, 2019

@GrahamcOfBorg test installer

@mmahut
Copy link
Member

mmahut commented Aug 15, 2019

Tested the script, found no issues.

@mmahut mmahut merged commit 08749c4 into NixOS:master Aug 15, 2019
@lschuermann lschuermann deleted the nixos-enter-silent branch October 25, 2019 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants