Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cgminer cleanup #61823

Merged
merged 2 commits into from May 29, 2019
Merged

Cgminer cleanup #61823

merged 2 commits into from May 29, 2019

Conversation

ambrop72
Copy link
Contributor

Motivation for this change

cgminer uses deprecated AMD libraries instead of relying on standard OpenCL libraries. While it is true that recent cgminer even dropped OpenCL support (#25039), we still shouldn't be keeping these deprecated libraries around if it's easy not to.

Things done

Builds and mining using OpenCL with NVIDIA seems to work.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@joachifm
Copy link
Contributor

@GrahamcOfBorg build cgminer

@joachifm joachifm merged commit 7eb4b83 into NixOS:master May 29, 2019
@oxij oxij mentioned this pull request Jun 22, 2019
Merged
oxij added a commit to oxij/nixpkgs that referenced this pull request Jun 22, 2019
@oxij
Revert "Remove amdadlsdk and amdappsdk."
c42f378 
This reverts commit 08ea7c7.

This was a part of NixOS#61823.

Firstly, that commit removed those attributes without removing the files
they refer to, which is strange.

Secondly, I have a very old but GPGPU-capabale AMD card which doesn't work
with newer OpenCL infrastructure and hence needs these packages to do GPGPU.
This was referenced Apr 28, 2020
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: clean-up 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ambrop72 @joachifm