Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

thunderbird, thunderbird-bin: 60.6.0 -> 60.7.0 #61877

Merged
merged 2 commits into from Jun 9, 2019
Merged

thunderbird, thunderbird-bin: 60.6.0 -> 60.7.0 #61877

merged 2 commits into from Jun 9, 2019

Conversation

taku0
Copy link
Contributor

@taku0 taku0 commented May 22, 2019 •
edited

Motivation for this change
  • Critical security fix
  • Attachment pane of Write window no longer focussed when attaching files using a keyboard shortcut

https://www.thunderbird.net/en-US/thunderbird/60.7.0/releasenotes/
https://www.mozilla.org/en-US/security/advisories/mfsa2019-15/

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Both thunderbird-bin and thunderbird are tested.

@ofborg ofborg bot requested review from nbp and edolstra May 22, 2019 12:03
vcunat
vcunat approved these changes Jun 9, 2019
View reviewed changes
Copy link
Member

@vcunat vcunat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both seem to work fine for me.

pull bot pushed a commit to avitex/nixpkgs that referenced this pull request Jun 9, 2019
@vcunat
Merge NixOS#61877: thunderbird*: 60.6.0 -> 60.7.0 (security)
e8f8df0
@vcunat vcunat merged commit f397dda into NixOS:master Jun 9, 2019
vcunat added a commit that referenced this pull request Jun 9, 2019
@vcunat
Merge #61877: thunderbird*: 60.6.0 -> 60.7.0 (security)
3ee495e 
(cherry picked from commit e8f8df0)
thunderbird-bin gets actually bumped from 60.5.1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vcunat vcunat vcunat approved these changes

@nbp nbp Awaiting requested review from nbp

@edolstra edolstra Awaiting requested review from edolstra

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@taku0 @vcunat