Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adds nodejs_latest packages #61838

Merged
merged 2 commits into from May 22, 2019
Merged

adds nodejs_latest packages #61838

merged 2 commits into from May 22, 2019

Conversation

sonercirit
Copy link
Contributor

@sonercirit sonercirit commented May 21, 2019 •
edited

Motivation for this change

Well, from what I've understand nodejs package is version locked to v8 for compatibility reasons, but this makes it hard for people who want to stay on the latest release. Current latest package is nodejs-12_x but after a while v13 will release and we will have a package called nodejs-13_x and most people will miss this update. So I propose nodejs-latest package definitions.

Thanks to @samueldr, @alexarice , @infinisil from IRC :)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

I've tested these packages with the following:

cd into root of project
nix-build -A nodejs-latest
nix-shell -p nodejs-latest -I nixpkgs=.

@jonringer
Copy link
Contributor

As per https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md you'll probably want to squash all the commits into one per package added, and have the commits be something along the lines of nodejs-latest: init at v12 and nodejs-slim-latest: init at v12. I'm not 100% sure what the protocol for aliases are.

@sonercirit
Copy link
Contributor Author

As per https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md you'll probably want to squash all the commits into one per package added, and have the commits be something along the lines of nodejs-latest: init at v12 and nodejs-slim-latest: init at v12. I'm not 100% sure what the protocol for aliases are.

Should be good now :) Ty for mentioning

@sonercirit sonercirit changed the title adds nodejs-latest packages adds nodejs_latest packages May 22, 2019
@sonercirit
Copy link
Contributor Author

@infinisil changed the package, commit and pr names accordingly

@infinisil infinisil merged commit 241530b into NixOS:master May 22, 2019
@infinisil
Copy link
Member

Looking good thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexarice alexarice alexarice left review comments

@infinisil infinisil infinisil left review comments

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@sonercirit @jonringer @infinisil @alexarice @Janik-Haag