Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nginxMainline: 1.16.0 -> 1.17.2 #61816

Merged
merged 1 commit into from Jul 25, 2019
Merged

nginxMainline: 1.16.0 -> 1.17.2 #61816

merged 1 commit into from Jul 25, 2019

Conversation

Izorkin
Copy link
Contributor

@Izorkin Izorkin commented May 21, 2019 •
edited

Motivation for this change

Update nginxMainline to 1.17.0
Changes with nginx 1.17.0:

  • Feature: variables support in the "limit_rate" and "limit_rate_after" directives.
  • Feature: variables support in the "proxy_upload_rate" and "proxy_download_rate" directives in the stream module.
  • Change: minimum supported OpenSSL version is 0.9.8.
  • Change: now the postpone filter is always built.
  • Bugfix: the "include" directive did not work inside the "if" and "limit_except" blocks.
  • Bugfix: in byte ranges processing.
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Izorkin
Copy link
Contributor Author

Izorkin commented May 21, 2019

@GrahamcOfBorg build nginxMainline

tomberek
tomberek approved these changes May 21, 2019
View reviewed changes
Copy link
Contributor

@tomberek tomberek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Builds, runs, functions on Ubuntu. Tested with relatively basic configuration: HTTPS, several endpoints, custom headers, proxy settings.

@Izorkin Izorkin changed the title nginxMainline: 1.16.0 -> 1.17.0 nginxMainline: 1.16.0 -> 1.17.1 Jun 25, 2019
@Izorkin
Copy link
Contributor Author

Izorkin commented Jun 25, 2019

Update to version 1.17.1

@Izorkin
Copy link
Contributor Author

Izorkin commented Jun 25, 2019

@GrahamcOfBorg build nginxMainline

@Izorkin Izorkin changed the title nginxMainline: 1.16.0 -> 1.17.1 nginxMainline: 1.16.0 -> 1.17.2 Jul 24, 2019
@Izorkin
Copy link
Contributor Author

Izorkin commented Jul 24, 2019

Update to version 1.17.2

@Izorkin
Copy link
Contributor Author

Izorkin commented Jul 24, 2019

@GrahamcOfBorg build nginxMainline

@Izorkin
Copy link
Contributor Author

Izorkin commented Jul 24, 2019

cc @Mic92 @xeji @fpletz

@Mic92 Mic92 merged commit 8044f32 into NixOS:master Jul 25, 2019
@Izorkin Izorkin deleted the nginxMainline branch July 25, 2019 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomberek tomberek tomberek approved these changes

@fadenb fadenb fadenb approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Izorkin @tomberek @fadenb @Mic92