Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lua*Packages TLS updates #61818

Merged
merged 2 commits into from May 23, 2019
Merged

lua*Packages TLS updates #61818

merged 2 commits into from May 23, 2019

Conversation

vcunat
Copy link
Member

@vcunat vcunat commented May 21, 2019

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via all NixOS test(s) if existing and applicable for the change (look inside nixos/tests) prosody.x86_64-linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • N/A Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after). A couple kilobytes added.
  • N/A, I think. Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

I tried generating these, but they wouldn't build, even if I overrode them to depend on openssl. (I don't know what's wrong.)

So far I've done mainly basic testing around knot-resolver, but even https with TLS 1.3 seemed to work when I added the openssl-1.1 branch locally.

@teto
Copy link
Member

teto commented May 22, 2019

luasec seems to be on luarocks, wouldn't that makes sense to move it to the automated packages instead ?

@teto
Copy link
Member

teto commented May 22, 2019

luaossl too for what it's worth xD . If you are willing to go through the process and have any trouble/question let me know.

@vcunat
Copy link
Member Author

vcunat commented May 22, 2019

Feel free to try.

I tried generating these, but they wouldn't build, even if I overrode them to depend on openssl. (I don't know what's wrong.)

@teto
Copy link
Member

teto commented May 22, 2019

sorry completely missed this. Ok will try.

@vcunat
Copy link
Member Author

vcunat commented May 22, 2019

The generated expression didn't contain openssl reference (not surprising), so I added it to buildInputs via the usual overrides, but they still couldn't find headers from the package. I was probably doing something wrong; in any case I chose a quicker solution for now.

@teto
Copy link
Member

teto commented May 22, 2019

if you feel confident enough to merge it, let's do it, I will investiage the issue later.
luarocks makes some assumptions on how paths are searched, so for instance if it finds X/include, it will look for the lib in X/lib and ignore Y/lib (or something along these lines IIRC) which is why sometimes it's necessary to specify manually the folders like

    extraConfig = ''
      variables = {
        LIBUUID_INCDIR="${pkgs.lib.getDev pkgs.libuuid}/include";
        LIBUUID_LIBDIR="${pkgs.lib.getLib pkgs.libuuid}/lib";
      }
    '';

upstream didn't seem too excited about "fixing" this. so maybe I could do it in our fork.

@vcunat
Copy link
Member Author

vcunat commented May 22, 2019

It would be best to support and prefer pkg-config to search for dependencies.

@teto
Copy link
Member

teto commented May 22, 2019

I can only agree luarocks/luarocks#514

@teto teto merged commit 3a7a7a7 into NixOS:master May 23, 2019
@vcunat vcunat deleted the p/lua-tls branch May 25, 2019 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants