docear: init at 1.2.0 #61817
docear: init at 1.2.0 #61817
Conversation
| stdenv.mkDerivation rec { | ||
| pname = "docear"; | ||
| version = "1.2"; | ||
| name = "${pname}-${version}"; |
There was a problem hiding this comment.
This is actually already set so you can omit it.
|
|
||
| meta = with stdenv.lib; { | ||
| description = "A unique solution to academic literature management"; | ||
| homepage = http://www.docear.org/; |
There was a problem hiding this comment.
Is this a new practice? Most URLs in nixpkgs are actually unquoted.
There was a problem hiding this comment.
Yes. Very new. Unquoted urls are going to eventually be deprecated. You don't have to quote it right now, but minimal effort now saves some time later when it has become deprecated.
| chmod 0755 $out/share/ -R | ||
|
|
||
| # The wrapper ensures oraclejre is used | ||
| echo "#!${runtimeShell}" > $out/bin/docear |
There was a problem hiding this comment.
You're looking for makeWrapper here. If you do a search on github for makeWrapper + jre I'm sure you'll find a number of examples. If not, feel free to ask for further help.
| sha256 = "1g5n7r2x4gas6dl2fbyh7v9yxdcb6bzml8n3ldmpzv1rncgjcdp4"; | ||
| }; | ||
|
|
||
| phases = [ "unpackPhase" "installPhase" ]; |
There was a problem hiding this comment.
You should omit this as I believe it is or will be deprecated. Either way it isn't a good idea.
Stable URLs are only provided for older versions.
|
@aanderse thanks for the review. I implemented most of your suggestions with exception of the point about stable urls. Unfortunately given the link above, the lack of a stable url for the most recent version seems deliberate. |
Motivation for this change
Adding Docear - an academic literature suite
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)As per terms of service (bottom of page) some optional functionality included in the software may fall under
nonfreelicense.