Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cri-o: update to all packages #61792

Merged
merged 1 commit into from May 28, 2019
Merged

cri-o: update to all packages #61792

merged 1 commit into from May 28, 2019

Conversation

saschagrunert
Copy link
Member

@saschagrunert saschagrunert commented May 21, 2019 •
edited

Motivation for this change

Add CRI-O to the all packages file, which has been missed with the init
commit.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@saschagrunert
cri-o: update to all packages
34d15b3 
Add CRI-O to the all packages file, which has been missed with the init
commit.

Signed-off-by: Sascha Grunert <sgrunert@suse.com>
@risicle
Copy link
Contributor

risicle commented May 27, 2019

Builds for me, non-nixos linux s86_64

@Mic92
Copy link
Member

Mic92 commented May 27, 2019

@GrahamcOfBorg build cri-o

@infinisil infinisil merged commit cc06576 into NixOS:master May 28, 2019
@saschagrunert saschagrunert deleted the cri-o-all-packages branch May 28, 2019 05:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@saschagrunert @risicle @Mic92 @infinisil