Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

borgbackup: 1.1.9 -> 1.1.10 #61793

Merged
merged 2 commits into from May 21, 2019
Merged

borgbackup: 1.1.9 -> 1.1.10 #61793

merged 2 commits into from May 21, 2019

Conversation

r-ryantm
Copy link
Contributor

Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/borgbackup/versions.

meta.description for borgbackup is: '"A deduplicating backup program (attic fork)"'.

meta.homepage for borgbackup is: '"https://www.borgbackup.org"

Checks done (click to expand)
Rebuild report (if merged into master) (click to expand)

4 total rebuild path(s)

1 package rebuild(s)

1 x86_64-linux rebuild(s)
1 i686-linux rebuild(s)
1 x86_64-darwin rebuild(s)
1 aarch64-linux rebuild(s)

First fifty rebuilds by attrpath
borgbackup

Instructions to test this update (click to expand)

Either download from Cachix:

nix-store -r /nix/store/4m7p421h0831sq45rlp7xk4fp84vw4xx-borgbackup-1.1.10 \
  --option binary-caches 'https://cache.nixos.org/ https://r-ryantm.cachix.org/' \
  --option trusted-public-keys '
  r-ryantm.cachix.org-1:gkUbLkouDAyvBdpBX0JOdIiD2/DP1ldF3Z3Y6Gqcc4c=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(r-ryantm's Cachix cache is only trusted for this store-path realization.)

Or, build yourself:

nix-build -A borgbackup https://github.com/r-ryantm/nixpkgs/archive/f4b8412198b33365d39f476b6516453845800557.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:

ls -la /nix/store/4m7p421h0831sq45rlp7xk4fp84vw4xx-borgbackup-1.1.10
ls -la /nix/store/4m7p421h0831sq45rlp7xk4fp84vw4xx-borgbackup-1.1.10/bin

cc @flokli @dotlambda for testing.

@r-ryantm
borgbackup: 1.1.9 -> 1.1.10
f4b8412 
Semi-automatic update generated by
https://github.com/ryantm/nixpkgs-update tools. This update was made
based on information from
https://repology.org/metapackage/borgbackup/versions
@ofborg ofborg bot requested review from dotlambda and flokli May 21, 2019 08:04
@c0bw3b
Copy link
Contributor

c0bw3b commented May 21, 2019

@GrahamcOfBorg test borgbackup

@c0bw3b
Copy link
Contributor

c0bw3b commented May 21, 2019

Announce: https://github.com/borgbackup/borg/releases/tag/1.1.10
Changelog: https://github.com/borgbackup/borg/blob/1.1.10/docs/changes.rst#version-1110-2019-05-16

bundle latest supported msgpack-python release (0.5.6), remove msgpack-python from setup.py install_requires

So the python3 override may not be needed anymore.

@flokli
borgbackup: remove custom msgpack-python override, use bundled version
5d4b383 
https://github.com/borgbackup/borg/blob/1.1.10/docs/changes.rst#version-1110-2019-05-16
mentions borgbackup now shipping a supported msgpack-python release, and
strongly encourages using that one.

So don't pass any msgpack-python into the build, and use the provided
one.
@flokli
Copy link
Contributor

flokli commented May 21, 2019

I updated the derivation to not pass in any msgpack-python, instead use the one bundled with borgbackup itself, as the former seems to be strongly discouraged:

optionally, we still support using an external msgpack (see hints in setup.py), but this requires solid requirements management within distributions and is not recommended. borgbackup will break if you upgrade msgpack to an unsupported version.

with that change, borgbackup vm tests still pass, so this seems to work :-)

@ryantm ryantm merged commit aa355be into NixOS:master May 21, 2019
@r-ryantm r-ryantm deleted the auto-update/borgbackup branch May 24, 2019 04:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flokli flokli flokli approved these changes

@dotlambda dotlambda Awaiting requested review from dotlambda

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@r-ryantm @c0bw3b @flokli @ryantm