Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

firefox: 66.0.5 -> 67.0,firefox-bin: 66.0.5 -> 67.0, firefox-esr-60: 60.6.3esr -> 60.7.0esr #61757

Merged
merged 4 commits into from May 21, 2019
Merged

firefox: 66.0.5 -> 67.0,firefox-bin: 66.0.5 -> 67.0, firefox-esr-60: 60.6.3esr -> 60.7.0esr #61757

merged 4 commits into from May 21, 2019

Conversation

andir
Copy link
Member

@andir andir commented May 20, 2019 •
edited

Motivation for this change

Updated firefox to the latest version. Writing this message using the x86_64 built for unstable.

https://www.mozilla.org/en-US/firefox/67.0/releasenotes/

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

andir added 2 commits May 20, 2019 18:29
@andir
firefox: prepare for firefox 67.0 release
7f65d06 
Firefox now requires `llvm-objdump` during the build phase. The aarch64
patches do no longer apply. So far I am guessing that they have been
merged. We should verify that.
@andir
firefox: 66.0.5 -> 67.0
f353c0e
@ofborg ofborg bot requested a review from edolstra May 20, 2019 17:41
@andir
Copy link
Member Author

andir commented May 20, 2019

Working on the backport.. It requires a larger amount of rebuilds (NSS, NSPR, Sqlite, …) so will sadly be a bit longer (this time) until the PR will appear.

@andir andir mentioned this pull request May 20, 2019
Closed
10 tasks
@andir andir changed the title firefox: 66.0.5 -> 67.0 firefox: 66.0.5 -> 67.0,firefox-bin: 66.0.5 -> 67.0 May 21, 2019
@andir andir changed the title firefox: 66.0.5 -> 67.0,firefox-bin: 66.0.5 -> 67.0 firefox: 66.0.5 -> 67.0,firefox-bin: 66.0.5 -> 67.0, firefox-esr-60: 60.6.3esr -> 60.7.0esr May 21, 2019
@andir andir changed the title firefox: 66.0.5 -> 67.0,firefox-bin: 66.0.5 -> 67.0, firefox-esr-60: 60.6.3esr -> 60.7.0esr firefox: 66.0.5 -> 67.0,firefox-bin: 66.0.5 -> 67.0, firefox-esr-60: 60.6.3esr -> 60.7.0esr May 21, 2019
@andir andir merged commit 3906e98 into NixOS:master May 21, 2019
@andir andir deleted the firefox67 branch May 21, 2019 06:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edolstra edolstra Awaiting requested review from edolstra

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@andir