Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase dimension line offset from text #340

Closed
ghost opened this issue Jul 28, 2018 · 9 comments
Closed

Increase dimension line offset from text #340

ghost opened this issue Jul 28, 2018 · 9 comments
Milestone

Comments

@ghost
Copy link

ghost commented Jul 28, 2018

System information

SolveSpace version: 3.0~8426992f

Operating system: Debian 9 "Stretch"

Expected behavior

Offset from dimension value text to dimension line.

Actual behavior

Currently horizontal offset equal 1 px, that is too close.

In same time vertical offset equal 3 px.

Additional information

pic1

pic2

pic3

pic4

@Evil-Spirit
Copy link
Collaborator

Also probably we should get rid of REF. Just use ISO ANSI GOST or some other approach.

@whitequark
Copy link
Contributor

ISO does not specify parametric sketches, so it's fine that we depart from ISO where parametricity is required.

@Evil-Spirit
Copy link
Collaborator

Evil-Spirit commented Jul 30, 2018

I mean, drawing standarts have common approach to specify reference dimensions. for ex. in GOST "*" is used:
image

@whitequark
Copy link
Contributor

@Evil-Spirit Oh, I didn't know that. Thanks.

@ghost
Copy link
Author

ghost commented Jul 30, 2018

in GOST "*" is used

Depending on used font, "*" should be also in <sup> position.

  • X*: X*
  • X<sup>*</sup>: X*

As described in GOST, "*" (U+002A ASTERISK) should be "upper placed" 6-ray star,...

pic1

... but current internal SolveSpace font has "bottom placed" 5-ray star.

pic2

@ghost
Copy link
Author

ghost commented Jul 31, 2018

For the record, here is ISO 129: "Technical drawings — Indication of dimensions and tolerances"

@whitequark
Copy link
Contributor

Fixed in eda294e, thanks for the report.

@ghost
Copy link
Author

ghost commented Aug 2, 2018

Fixed in eda294e, thanks for the report.

It's look like Angle constraint text still look buggy:

pic1

Can you fix it too?

@whitequark whitequark reopened this Aug 2, 2018
@whitequark
Copy link
Contributor

Fixed in 25b6eba.

@whitequark whitequark added this to the 3.0 milestone May 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants