Automatically resize the Three.js view to fit window if the size was not forced #420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…not explicitly specified in Three.js viewer
|
This looks good but incomplete, because while resizing recenters the model, it doesn't adjust its scale. Do you think you could try to handle that as well? |
|
Not sure what the state-of-the-art correct way of handling this is, but code from new commit behaves pretty much like I'd expect scaling on resize to behave? |
|
Thank you, merged as e243396. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resizing the browser window had no effect, leading to requiring a reload. With this patch the view size follows the browser's, if not overridden in
params.I arrived at this code by blind-hacking at the export, so am not sure if all is up to standard (the
render()call in particular).