Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: solvespace/solvespace
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 9500487a3f7f
Choose a base ref
...
head repository: solvespace/solvespace
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 25b6eba148a9
Choose a head ref
  • 1 commit
  • 5 files changed
  • 1 contributor

Commits on May 21, 2019

  1. Copy the full SHA
    25b6eba View commit details
6 changes: 3 additions & 3 deletions src/drawconstraint.cpp
Original file line number Diff line number Diff line change
@@ -349,8 +349,8 @@ void Constraint::DoArcForAngle(Canvas *canvas, Canvas::hStroke hcs,
double r = max(sqrt(rda*rda + rdna*rdna), 15.0 * pixels);

double th = Style::TextHeight(GetStyle()) / camera.scale;
double swidth = VectorFont::Builtin()->GetWidth(th, Label()) + 4*pixels,
sheight = VectorFont::Builtin()->GetCapHeight(th) + 8*pixels;
double swidth = VectorFont::Builtin()->GetWidth(th, Label()) + 8*pixels,
sheight = VectorFont::Builtin()->GetCapHeight(th) + 6*pixels;
double textR = sqrt(swidth * swidth + sheight * sheight) / 2.0;
*ref = pi.Plus(rm.WithMagnitude(std::max(rm.Magnitude(), 15 * pixels + textR)));

@@ -412,7 +412,7 @@ void Constraint::DoArcForAngle(Canvas *canvas, Canvas::hStroke hcs,
if(i > 0) {
if(trim) {
DoLineTrimmedAgainstBox(canvas, hcs, *ref, prev, p,
/*extend=*/false, gr, gu, swidth, sheight);
/*extend=*/false, gr, gu, swidth, sheight + 2*pixels);
} else {
DoLine(canvas, hcs, prev, p);
}
Binary file modified test/constraint/angle/free_in_3d.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified test/constraint/angle/normal.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified test/constraint/angle/reference.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified test/constraint/angle/reference_free_in_3d.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.