Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hotspot: 1.0.0 -> 1.2.0 #61767

Merged
merged 1 commit into from May 20, 2019
Merged

hotspot: 1.0.0 -> 1.2.0 #61767

merged 1 commit into from May 20, 2019

Conversation

nh2
Copy link
Contributor

@nh2 nh2 commented May 20, 2019

Motivation for this change

Latest version.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

I need somebody to test this for me on NixOS, as on Ubuntu the GUI fails to start with qt.qpa.plugin: Coul dnot find the Qt platform plugin "xcb" in "". (This was already the case with hotspot 1.0.0.)

@nh2
Copy link
Contributor Author

nh2 commented May 20, 2019

@GrahamcOfBorg build hotspot

worldofpeace
worldofpeace approved these changes May 20, 2019
View reviewed changes
Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Built and executed for me when using nix-env -i ./result hotspot.
I'm using a DE and NixOS (ack IRC).

@worldofpeace
Copy link
Contributor

Release Notes:
https://github.com/KDAB/hotspot/releases/tag/v1.1.0
https://github.com/KDAB/hotspot/releases/tag/v1.2.0

@nh2
Copy link
Contributor Author

nh2 commented May 20, 2019

@worldofpeace Thanks!

@nh2 nh2 merged commit 4ee5fff into NixOS:master May 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace worldofpeace approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nh2 @worldofpeace