Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

aliza: 1.36.3 -> 1.48.10 #61798

Merged
merged 1 commit into from May 24, 2019
Merged

aliza: 1.36.3 -> 1.48.10 #61798

merged 1 commit into from May 24, 2019

Conversation

bobvanderlinden
Copy link
Member

Motivation for this change

Currently the aliza package doesn't have a version defined. This results in parsing errors in tools like Repology.
In addition, it is unclear for maintainers to determine which version is in Nixpkgs. I currently have determined the older version by running Aliza and going to Application -> About.

This PR upgrades aliza to 1.48.10. It only defines a RPM package for Linux, so I have specified the platform as well.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@c0bw3b
Copy link
Contributor

c0bw3b commented May 24, 2019

The previous src link points to v1.36.3 so I guess the link is stable over time, ie the source archive is not replaced when a new release is published.

c0bw3b
c0bw3b approved these changes May 24, 2019
View reviewed changes
Copy link
Contributor

@c0bw3b c0bw3b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Builds and runs

@c0bw3b c0bw3b merged commit 70a494a into NixOS:master May 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@c0bw3b c0bw3b c0bw3b approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bobvanderlinden @c0bw3b