Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.fire: fix python 3.7 build #61773

Merged
merged 1 commit into from May 21, 2019
Merged

pythonPackages.fire: fix python 3.7 build #61773

merged 1 commit into from May 21, 2019

Conversation

marsam
Copy link
Contributor

@marsam marsam commented May 21, 2019

Motivation for this change

Fixes #61770
cc: @abathur

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@marsam marsam requested a review from FRidh as a code owner May 21, 2019 00:27
@jonringer
Copy link
Contributor

Confirmed on NixOS using sandbox. Fire is able to be built.

LGTM

@marsam marsam merged commit 554d6cf into NixOS:master May 21, 2019
@marsam marsam deleted the fix-python-fire-build branch May 21, 2019 03:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

python-fire: build error caused by unified diff test failure
2 participants
@marsam @jonringer