Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.mypy: 0.700 -> 0.701 #61774

Merged
merged 1 commit into from May 21, 2019
Merged

pythonPackages.mypy: 0.700 -> 0.701 #61774

merged 1 commit into from May 21, 2019

Conversation

jonringer
Copy link
Contributor

Motivation for this change

Update package to latest

removed lxml as it isn't needed by the package according to the setup.py https://github.com/python/mypy/blob/master/setup.py#L181 and was moved to a test dependency.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Closure size:

nix path-info -Sh /nix/store/9hcdyp60xyjsdqqsxghsn88kmf63w3j4-python3.5-mypy-0.700
/nix/store/9hcdyp60xyjsdqqsxghsn88kmf63w3j4-python3.5-mypy-0.700         111.4M
nix path-info -Sh /nix/store/4dcm8c8hfl3h0zmfnkl8xa47wwjdvzi9-python3.5-mypy-0.701
/nix/store/4dcm8c8hfl3h0zmfnkl8xa47wwjdvzi9-python3.5-mypy-0.701         104.5M

@jonringer jonringer requested a review from FRidh as a code owner May 21, 2019 00:36
@ofborg ofborg bot requested a review from LnL7 May 21, 2019 01:08
@FRidh
Copy link
Member

FRidh commented May 21, 2019

@GrahamcOfBorg build python3Packages.mypy

c0bw3b
c0bw3b approved these changes May 21, 2019
View reviewed changes
Copy link
Contributor

@c0bw3b c0bw3b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nix-review'ed:
4 package were build:
mypy nix-pin python37Packages.pyls-mypy python37Packages.pytest-mypy

@c0bw3b
Copy link
Contributor

c0bw3b commented May 21, 2019

I guess lxml could be removed on 1st line too? Or listed in checkInputs but checks are disabled here anyway.

@jonringer
Copy link
Contributor Author

removed lxml input, thanks @c0bw3b

@c0bw3b
Copy link
Contributor

c0bw3b commented May 21, 2019

@GrahamcOfBorg build mypy python37Packages.mypy python37Packages.mypy_extensions python37Packages.pyls-mypy python37Packages.pytest-mypy

@c0bw3b c0bw3b merged commit c2bac60 into NixOS:master May 21, 2019
@jonringer jonringer deleted the bump_mypy0.701 branch July 9, 2019 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@c0bw3b c0bw3b c0bw3b approved these changes

@FRidh FRidh Awaiting requested review from FRidh

@LnL7 LnL7 Awaiting requested review from LnL7

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jonringer @FRidh @c0bw3b