Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

freerdp: add nocaps option that turns Caps Lock into Control #61858

Merged
merged 1 commit into from Jun 9, 2019
Merged

freerdp: add nocaps option that turns Caps Lock into Control #61858

merged 1 commit into from Jun 9, 2019

Conversation

ghost
Copy link

@ghost ghost commented May 22, 2019

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@peterhoeg
Copy link
Member

@GrahamcOfBorg build freerdp

@peterhoeg
Copy link
Member

@cf6b88f, there is no way this can be done at runtime?

@ghost
Copy link
Author

ghost commented Jun 3, 2019 via email

@peterhoeg
Copy link
Member

OK, so if we can't do it at runtime, we will need this approach. Please change the morePrePatch bit though and just do it as part of the prePatch phase.

@cizra
Copy link
Contributor

cizra commented Jun 7, 2019

@peterhoeg done

@peterhoeg peterhoeg merged commit 4d2bd93 into NixOS:master Jun 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants