Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gtk{2,3}-x11: build against cairo with X11 support enabled #61912

Merged
merged 1 commit into from May 23, 2019
Merged

gtk{2,3}-x11: build against cairo with X11 support enabled #61912

merged 1 commit into from May 23, 2019

Conversation

smaret
Copy link
Member

@smaret smaret commented May 22, 2019

Motivation for this change

On Darwin cairo does not have X11 support enabled by default, but gtk{2,3}-x11 requires it. Force gtk{2,3}-x11 to be built against cairo with X11 support enabled. Fixes #61891.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@smaret
gtk{2,3}-x11: build against cairo with X11 support enabled
f3ced69 
On Darwin cairo does not have X11 support enabled by default, but
gtk{2,3}-x11 requires it. Force gtk{2,3}-x11 to be built against cairo
with X11 support enabled. Fixes NixOS#61891.
@smaret
Copy link
Member Author

smaret commented May 22, 2019

@GrahamcOfBorg build gtk2-x11

@smaret
Copy link
Member Author

smaret commented May 22, 2019

@GrahamcOfBorg build gtk3-x11

@matthewbauer matthewbauer merged commit 522c7d5 into NixOS:master May 23, 2019
@smaret smaret deleted the gtk-x11-fix branch May 23, 2019 10:20
@smaret smaret mentioned this pull request May 23, 2019
Merged
10 tasks
@dhruvio dhruvio mentioned this pull request May 24, 2019
Merged
10 tasks
@rvolosatovs rvolosatovs mentioned this pull request Sep 19, 2019
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

gtk{2,3}-x11 fails to build on Darwin
2 participants
@smaret @matthewbauer