Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

video2midi: init at 0.3.7 #61826

Merged
merged 2 commits into from Jun 23, 2019
Merged

video2midi: init at 0.3.7 #61826

merged 2 commits into from Jun 23, 2019

Conversation

ghost
Copy link

@ghost ghost commented May 21, 2019 •
edited by ghost

Motivation for this change

Youtube synthesia video to midi conversion tool

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ghost ghost requested a review from FRidh as a code owner May 21, 2019 18:37
alexarice
alexarice approved these changes Jun 6, 2019
View reviewed changes
Copy link
Contributor

@alexarice alexarice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I have run nix-review and tested the resulting program and it seems to work well.

pkgs/tools/audio/video2midi/default.nix Outdated Show resolved Hide resolved
@ghost
Copy link
Author

ghost commented Jun 7, 2019

@alexarice Corrected, thanks!

@ghost ghost changed the title video2midi: init at 0.3.5 video2midi: init at 0.3.7 Jun 12, 2019
@lheckemann
Copy link
Member

@GrahamcOfBorg build video2midi

@lheckemann
Copy link
Member

What will they come up with next?

@lheckemann lheckemann merged commit bd286ce into NixOS:master Jun 23, 2019
@ghost
Copy link
Author

ghost commented Jun 23, 2019

@lheckemann 😄 Thank you!

@ghost ghost deleted the video2midi branch June 23, 2019 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lheckemann @alexarice