multipath-tools: 0.6.2 -> 0.8.1 (cont. https://github.com/NixOS/nixpkgs/pull/61824) #61828
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 26, 2019 09:56
NOTES:
- `DEFAULT_MULTIPATHDIR` is set via adjusted make variables.
- `DESTDIR` to `prefix` doesn't do anything so it was dropped. In
previous versions there were some entries where it matched. E.g. in
0.5.0 it updated `kpartx/Makefile` with:
- $(INSTALL_PROGRAM) -d $(DESTDIR)/etc/udev/rules.d
- $(INSTALL_PROGRAM) -m 644 kpartx.rules $(DESTDIR)/etc/udev/rules.d/
+ $(INSTALL_PROGRAM) -d $(prefix)/etc/udev/rules.d
+ $(INSTALL_PROGRAM) -m 644 kpartx.rules $(prefix)/etc/udev/rules.d/
This is no longer needed as udev rules are correctly placed in recent
versions.
- Updating `GZIP` variable never worked as the pattern doesn't match
because there are multiple spaces before the equal sign in
`Makefile.vars`. This was dropped.
Also fixing library detection in Makefile. In the previous and the current
version `/usr/include` was hardcoded in Makefile. I have tested that all
optional features are found during build. Excerpt from build output:
Checking for dm_task_no_flush in /nix/store/d2x72ihg707mdjvbjz3n4s9v02syr86y-lvm2-2.03.01/include/libdevmapper.h ... yes
Checking for dm_task_set_cookie in /nix/store/d2x72ihg707mdjvbjz3n4s9v02syr86y-lvm2-2.03.01/include/libdevmapper.h ... yes
Checking for udev_monitor_set_receive_buffer_size in /nix/store/jvm37ymza8h2l74p0j0l3hxwwsnrha1l-systemd-239.20190219-dev/include/libudev.h ... yes
Checking for dm_task_deferred_remove in /nix/store/d2x72ihg707mdjvbjz3n4s9v02syr86y-lvm2-2.03.01/include/libdevmapper.h ... yes
Checking if /nix/store/rz560c4bc3czwzzlli1z2az7hxp8axlh-linux-headers-4.19.16/include/linux/nvme_ioctl.h exists ... yes
|
@vlaci Is this PR still relevant? Newest version of multipath-tools in master is 0.8.2. :) |
|
No, it already has been integrated somehow ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #61824. I am not sure if this PR would be mergaable as is so I have split in two.
Motivation for this change
Also fixing library detection in Makefile. In the previous and the current
version
/usr/includewas hardcoded in Makefile. I have tested that alloptional features are found during build. Excerpt from build output:
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)