Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

openssl: cve-2019-1543 #61827

Closed
wants to merge 1 commit into from
Closed

openssl: cve-2019-1543 #61827

wants to merge 1 commit into from

Conversation

tomberek
Copy link
Contributor

Motivation for this change

Fixes #60107
Get involved with security patches, feedback welcome.

Things done

Pulled patch from openssl mailing list. Added patch to openssl_1_1

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from peti May 21, 2019 20:43
peti
peti requested changes May 22, 2019
View reviewed changes
Copy link
Member

@peti peti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we download that patch from somewhere (upstream?) rather than checking a copy into the nixpkgs repository?

@tomberek
openssl: cve-2019-1543
56d52fd 
Modified to fetch the patch instead
@tomberek
Copy link
Contributor Author

@peti : sure, see update.

@peti
Copy link
Member

peti commented May 22, 2019

@GrahamcOfBorg build openssl openssl_1_1

@ofborg ofborg bot requested a review from peti May 22, 2019 14:07
@peti peti changed the base branch from master to staging May 22, 2019 15:04
@peti peti changed the base branch from staging to master May 22, 2019 15:05
@peti
Copy link
Member

peti commented May 22, 2019

Merged to staging in aae4c11.

@peti peti closed this May 22, 2019
peti pushed a commit that referenced this pull request May 22, 2019
@tomberek @peti
openssl: fix CVE-2019-1543
aae4c11 
Closes #61827.
Fixes #60107.
vcunat pushed a commit that referenced this pull request May 23, 2019
@tomberek @vcunat
openssl: fix CVE-2019-1543
e4ee5b9 
Originally from #61827.

(cherry picked from commit aae4c11)
Fixes #58269.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peti peti Awaiting requested review from peti

Assignees
No one assigned
Labels
1.severity: security 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Vulnerability roundup 66: openssl-1.1.1b: 2 advisories
3 participants
@tomberek @peti @veprbl