Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nrfutil: init at 5.2.0 #61831

Merged
merged 5 commits into from May 21, 2019
Merged

nrfutil: init at 5.2.0 #61831

merged 5 commits into from May 21, 2019

Conversation

gebner
Copy link
Member

@gebner gebner commented May 21, 2019

Motivation for this change

nrfutil is a firmware flash utility for nRF microcontrollers.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@gebner gebner requested a review from FRidh as a code owner May 21, 2019 18:51
gebner
gebner commented May 21, 2019
View reviewed changes
pkgs/development/python-modules/pc-ble-driver-py/default.nix
preBuild = ''
pushd ../build
cmake ..
make -j $NIX_BUILD_CORES
Copy link
Member Author

@gebner gebner May 21, 2019 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This package is a bit tricky to build. There is a python/setup.py file, however the setup.py does not build the native extension. The native extension is instead built by a top-level cmake file that copies the binary into the python directory. The pypi packages bundle the pre-built binaries...

@gebner
Copy link
Member Author

gebner commented May 21, 2019

@GrahamcOfBorg eval
@GrahamcOfBorg build nrfutil

@gebner gebner merged commit 5d465ee into NixOS:master May 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@gebner