Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libmodsecurity: 3.0.2 -> 3.0.3 #61825

Merged
merged 1 commit into from May 22, 2019
Merged

libmodsecurity: 3.0.2 -> 3.0.3 #61825

merged 1 commit into from May 22, 2019

Conversation

Izorkin
Copy link
Contributor

@Izorkin Izorkin commented May 21, 2019 •
edited

Motivation for this change

Update libmodsecurity to 3.0.3

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Izorkin
Copy link
Contributor Author

Izorkin commented May 21, 2019

@GrahamcOfBorg build libmodsecurity

@c0bw3b
Copy link
Contributor

c0bw3b commented May 21, 2019 •
edited

This is faster to build with enableParallelBuilding = true;

doxygen should be into nativeBuildInputs.
And I think valgrind too but I'm not sure how it is used.. Needed for unit tests?

@Izorkin
Copy link
Contributor Author

Izorkin commented May 22, 2019

Thanks, updated PR.
This package need to work plugins modsecurity-nginx.

@c0bw3b c0bw3b merged commit 4c860fd into NixOS:master May 22, 2019
@Izorkin Izorkin deleted the libmodsecurity branch May 22, 2019 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@c0bw3b c0bw3b c0bw3b approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Izorkin @c0bw3b