Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gildas: 20190401_a -> 20190501_a #61895

Merged
merged 1 commit into from May 24, 2019
Merged

gildas: 20190401_a -> 20190501_a #61895

merged 1 commit into from May 24, 2019

Conversation

smaret
Copy link
Member

@smaret smaret commented May 22, 2019 •
edited

Motivation for this change

Update Gildas package to the latest upstream.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@smaret
Copy link
Member Author

smaret commented May 22, 2019 •
edited

Building on Darwin is blocked by #61891

@smaret
Copy link
Member Author

smaret commented May 23, 2019 •
edited

It builds fine on Darwin now, but binaries segfault because pango does not have X11 enabled by default. This is fixed by #61942 .

@smaret
Copy link
Member Author

smaret commented May 24, 2019 •
edited

Now that #61942 has been merged, I’ve rebased this PR on master. Gildas builds and runs fine on Darwin now. From my point of view this is ready to be merged.

@veprbl
Copy link
Member

veprbl commented May 24, 2019

cc @bzizou

@GrahamcOfBorg build gildas

veprbl
veprbl approved these changes May 24, 2019
View reviewed changes
Copy link
Member

@veprbl veprbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Builds on x86_64-linux and x86_64-darwin

@veprbl veprbl merged commit 785204f into NixOS:master May 24, 2019
@smaret smaret deleted the gildas-update branch May 25, 2019 06:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@veprbl veprbl veprbl approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@smaret @veprbl