Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

epubcheck: 4.2.0 -> 4.2.1 #61835

Merged
merged 1 commit into from May 22, 2019
Merged

epubcheck: 4.2.0 -> 4.2.1 #61835

merged 1 commit into from May 22, 2019

Conversation

eadwu
Copy link
Member

@eadwu eadwu commented May 21, 2019

epubcheck --help
epubcheck --version
Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Copy link
Contributor

@tomberek tomberek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Builds, runs, and functions on Ubuntu. No reverse dependencies.

@marsam marsam merged commit 457952a into NixOS:master May 22, 2019
@marsam
Copy link
Contributor

marsam commented May 22, 2019

Built and tested locally on NixOS and Darwin
Thanks!

@eadwu eadwu deleted the epubcheck/4.2.1 branch November 17, 2020 23:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants