Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lbdb: fix build for 0.48.1 #61795

Merged
merged 1 commit into from May 23, 2019
Merged

lbdb: fix build for 0.48.1 #61795

merged 1 commit into from May 23, 2019

Conversation

bfortz
Copy link
Contributor

@bfortz bfortz commented May 21, 2019

Motivation for this change

Incorporates an upstream bux fix for the broken 0.48.1 release (undefined exec_prefix).

Should be backported to 19.03 (or 19.03 should revert to 0.48).

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

pkgs/tools/misc/lbdb/default.nix Outdated Show resolved Hide resolved
@bfortz bfortz changed the title 0.48.1->0.48.2 Incorporates upstream bugfix (undefined exec_prefix) lbdb: fix build for 0.48.1 May 22, 2019
@c0bw3b
Copy link
Contributor

c0bw3b commented May 22, 2019

@GrahamcOfBorg build lbdb

@c0bw3b
Copy link
Contributor

c0bw3b commented May 22, 2019

It builds locally on nixos with nix-review

@c0bw3b c0bw3b added the 9.needs: port to stable A PR needs a backport to the stable release. label May 22, 2019
@marsam marsam merged commit 5b7dea1 into NixOS:master May 23, 2019
@marsam
Copy link
Contributor

marsam commented May 23, 2019

Thanks @bfortz

@bfortz bfortz deleted the lbdb branch February 17, 2024 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants