Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

certigo: init at 1.11.0 #61782

Merged
merged 1 commit into from May 21, 2019
Merged

certigo: init at 1.11.0 #61782

merged 1 commit into from May 21, 2019

Conversation

marsam
Copy link
Contributor

@marsam marsam commented May 21, 2019

Motivation for this change

Add https://github.com/square/certigo

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from kalbasit May 21, 2019 02:58
kalbasit
kalbasit approved these changes May 21, 2019
View reviewed changes
Copy link
Member

@kalbasit kalbasit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a nitpick.

pkgs/tools/admin/certigo/default.nix Show resolved Hide resolved
@kalbasit
Copy link
Member

kalbasit commented May 21, 2019 •
edited

@GrahamcOfBorg build certigo

@marsam I did not see Darwin's build, have you added yourself to ofborg's trusted users?

@kalbasit kalbasit merged commit 52146c5 into NixOS:master May 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kalbasit kalbasit kalbasit approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@marsam @kalbasit