Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/all-firmware: Enable facetimehd only for i686/x86_64 #61037

Merged
merged 1 commit into from May 21, 2019
Merged

nixos/all-firmware: Enable facetimehd only for i686/x86_64 #61037

merged 1 commit into from May 21, 2019

Conversation

bkchr
Copy link
Contributor

@bkchr bkchr commented May 6, 2019 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@bkchr
Copy link
Contributor Author

bkchr commented May 6, 2019

CC: @symphorien

@symphorien symphorien mentioned this pull request May 19, 2019
Closed
10 tasks
matthewbauer
matthewbauer reviewed May 19, 2019
View reviewed changes
Copy link
Member

@matthewbauer matthewbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why does this only work on x86?

@bkchr
Copy link
Contributor Author

bkchr commented May 21, 2019

@matthewbauer I don't know, but it bricked my raspberry pi build.

@matthewbauer
Copy link
Member

Alright looks okay for now. It seems to have been hit here as well:

#25223

@matthewbauer matthewbauer merged commit 6d036d5 into NixOS:master May 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewbauer matthewbauer matthewbauer left review comments

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bkchr @matthewbauer