Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up from #414 - this is my best attempt at getting one using my typical approach of populating with the explicitly-stated preferences, then iterating through "apply to file" and "correct config causing most apparent spurious changes". There are substantial inconsistencies that mean that whatever decision I make for some of these, it will introduce changes if it were applied all-over, but since that's not on the table anyway, this should be at least something. There were also a few where clang-format couldn't quite express the subtle distinctions I saw in the existing formatting, so I picked the overall less-intrusive one.
The file is commented to help you modify it as desired.
I also added a clang-tidy config file because the contributing doc says "braces around all the things" and that's not something clang-format can do (for some reason), you have to use clang-tidy. Doing so exposed me to the reality that it's a guideline very rarely followed - but if you'd like to enforce it, that clang-tidy file is a good way to do so. Something like this, assuming you have a build tree in
build/
...(Can't use run-clang-tidy here because it will result in things getting multiple sets of brackets, etc. Sadly must do it single-threaded like this, or have it save out the fixes and manually choose the ones to apply.)