I just ran nix-review on this and can confirm it's working fine.

@flokli thanks for the backport :)

We should probably always backport signal-desktop version bumps to the stable release.

Yes, that was a bit unfortunate... :o Normally I backport a bunch of updates ~30 days before the version on the stable channel expires (can e.g. be extracted from libexec/resources/app.asar -> {"buildExpiration":1563316653000} -> date --date="@1563316653" -> Wed Jul 17 00:37:33 CEST 2019). But it seems like I forgot to add a reminder to my calendar after the last backport (probably because there was no backport for 19.03 yet).

Backporting every update individually would unfortunately significantly increase my workload as I don't use a stable channel and have to use VMs for testing (I'm not sure if there was ever a problem, but I don't want to risk it and skip testing). If someone has time for it that would be great, if not I would continue as before and give my best to not miss any backports (could probably add a periodic reminder after that branch-offs as well to add a new reminder for the stable channel).

@primeos no worries. Thanks for maintaining :-)

I wasn't aware signal-desktop clients have an expiration date. Maybe we should add this in a comment in the derivation somewhere.

I added a nixos vm test in #61916, that does OCR on the "Link your phone to Signal Desktop" message

Assuming you already tested basic functionality on unstable and the vm test on 19.03 passed, I'd consider it highly unlikely this will break in other major ways. But whatever workflow works for you best :-)

I wasn't aware signal-desktop clients have an expiration date. Maybe we should add this in a comment in the derivation somewhere.

Good idea. I'll have a look at this for the next update (maybe I could automate it and use it for reminders as well).

I added a nixos vm test in #61916, that does OCR on the "Link your phone to Signal Desktop" message

Thanks :)

Assuming you already tested basic functionality on unstable and the vm test on 19.03 passed, I'd consider it highly unlikely this will break in other major ways. But whatever workflow works for you best :-)

I also think that it's safe to assume that the backport works, if it doesn't crash during the launch due to incompatible dependencies or other problems.

I backported to signal test to 19.03 too, so checking should be pretty simple :-)