Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nim: 0.19.4 -> 0.19.6 #61786

Closed
wants to merge 1 commit into from
Closed

nim: 0.19.4 -> 0.19.6 #61786

wants to merge 1 commit into from

Conversation

royneary
Copy link
Contributor

Motivation for this change
  • update to 0.19.6
  • update nodejs dependency to 11.x
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@royneary
nim: 0.19.4 -> 0.19.6
ba3f7a3 
- update to 0.19.6
- update nodejs dependency to 11.x
tomberek
tomberek approved these changes May 21, 2019
View reviewed changes
Copy link
Contributor

@tomberek tomberek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Builds, runs, functions on Ubuntu. Nim REPL (nrpl) tested.

@marsam
Copy link
Contributor

marsam commented May 29, 2019

@GrahamcOfBorg build nim

@royneary
Copy link
Contributor Author

royneary commented Jun 8, 2019

closed in favor of #62845

@royneary royneary closed this Jun 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomberek tomberek tomberek approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@royneary @marsam @tomberek