youtube-dl: 2019.05.11 -> 2019.05.20 #61785
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ofborg
bot
requested review from
fpletz,
Fuuzetsu,
Phreedom,
bluescreen303 and
AndersonTorres
mmahut
reviewed
May 21, 2019
There was a problem hiding this comment.
nix-review fails to build this pull request:
$ nix build --no-link --keep-going --max-jobs 1 --option build-use-sandbox true -f /root/.cache/nix-review/pr-61785-2/build.nix
builder for '/nix/store/sl8xr3m91mgvjs5bkpx10ni5l6p6849a-env.drv' failed with exit code 1; last 10 log lines:
no Makefile, doing nothing
glibPreInstallPhase
installing
glibPreFixupPhase
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/kjcvr0mwbjzjnqkqsxqscc7rbnygvwx9-env
strip is /nix/store/2dfjlvp38xzkyylwpavnh61azi0d168b-binutils-2.31.1/bin/strip
patching script interpreter paths in /nix/store/kjcvr0mwbjzjnqkqsxqscc7rbnygvwx9-env
checking for references to /build/ in /nix/store/kjcvr0mwbjzjnqkqsxqscc7rbnygvwx9-env...
mkdir: cannot create directory '/nix/store/kjcvr0mwbjzjnqkqsxqscc7rbnygvwx9-env': Not a directory
[0 built (1 failed), 0.0 MiB DL]
error: build of '/nix/store/sl8xr3m91mgvjs5bkpx10ni5l6p6849a-env.drv' failed
https://github.com/NixOS/nixpkgs/pull/61785
21 package were build:
bomi curseradio deepin.deepin-movie-reborn gnome-mpv kodi-cli lollypop mopidy-youtube mpc-qt mpv mpv-with-scripts persepolis plex-media-player python27Packages.mpv python27Packages.pafy python27Packages.youtube-dl python27Packages.youtube-dl-light python37Packages.mps-youtube python37Packages.mpv python37Packages.pafy youtubeDL youtube-dl-light
$ nix-shell /root/.cache/nix-review/pr-61785-2/shell.nix
[nix-shell:~/.cache/nix-review/pr-61785-2]#
[nix-shell:~/.cache/nix-review/pr-61785-2]# ./results/youtubeDL/bin/youtube-dl https://www.youtube.com/watch?v=O446XppZzXA
Fatal Python error: initsite: Failed to import the site module
Traceback (most recent call last):
File "/nix/store/hm6iw7j16i1r7ppvfagsyzzrb9zjbq7x-python2.7-setuptools-41.0.1/lib/python2.7/site-packages/site.py", line 73, in <module>
__boot()
File "/nix/store/hm6iw7j16i1r7ppvfagsyzzrb9zjbq7x-python2.7-setuptools-41.0.1/lib/python2.7/site-packages/site.py", line 26, in __boot
import imp # Avoid import loop in Python 3
File "/nix/store/s5f3vpmig33nk4zyk228q55wdydd3pc2-python3-3.7.3/lib/python3.7/imp.py", line 27, in <module>
import tokenize
File "/nix/store/s5f3vpmig33nk4zyk228q55wdydd3pc2-python3-3.7.3/lib/python3.7/tokenize.py", line 33, in <module>
import re
File "/nix/store/s5f3vpmig33nk4zyk228q55wdydd3pc2-python3-3.7.3/lib/python3.7/re.py", line 143, in <module>
class RegexFlag(enum.IntFlag):
AttributeError: module 'enum' has no attribute 'IntFlag'
[nix-shell:~/.cache/nix-review/pr-61785-2]#
|
Because you used nix-review which made a nix-shell mixing python interpreter versions it causes that error. |
|
backported in e1cd559 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Update
youtube-dlto the latest release.https://github.com/ytdl-org/youtube-dl/releases/tag/2019.05.20
NOTE: Updates to
youtube-dlshould be backported, thanks!Things done
sandboxinnix.confon non-NixOS)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)