Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[19.03] firefox 66.0.5 -> 67.0, firefox-bin: 66.0.5 -> 67.0, firefox-esr-60: 60.6.3esr -> 60.7.0esr #61765

Closed
wants to merge 10 commits into from

Conversation

andir
Copy link
Member

@andir andir commented May 20, 2019

Motivation for this change

Backport of #61757.

This firefox updated unfortunately required a few more package bumps. I have been running a rebuild of the bumped channel for a while now. So far it looks okay-ish. Hasn't finished though.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

r-ryantm and others added 8 commits May 20, 2019 21:26
Semi-automatic update generated by
https://github.com/ryantm/nixpkgs-update tools. This update was made
based on information from
https://repology.org/metapackage/rust-cbindgen/versions

(cherry picked from commit d882895)
(cherry picked from commit 885d1df)
Semi-automatic update generated by
https://github.com/ryantm/nixpkgs-update tools. This update was made
based on information from
https://repology.org/metapackage/nspr/versions

(cherry picked from commit 97fe2b0)
(cherry picked from commit f2f90f4)
Changelog: https://www.sqlite.org/releaselog/3_28_0.html

Security: includes fixes for CVE-2019-9936 and CVE-2019-9937
(cherry picked from commit fba13b5)
Firefox now requires `llvm-objdump` during the build phase.

(cherry picked from commit 7f65d06)
(cherry picked from commit f353c0e)
@jonringer
Copy link
Contributor

Successfully built and ran on NixOS with sandbox.

nix path-info -Sh /nix/store/m8ml8li5ll5m9kz5jf4pgapd8kd6gg9q-firefox-67.0
/nix/store/m8ml8li5ll5m9kz5jf4pgapd8kd6gg9q-firefox-67.0         506.6M

andir added 2 commits May 21, 2019 07:53
(cherry picked from commit 140096b)
@andir andir changed the title [19.03] firefox 66.0.5 -> 67.0 [19.03] firefox 66.0.5 -> 67.0, firefox-bin: 66.0.5 -> 67.0 May 21, 2019
@andir andir changed the title [19.03] firefox 66.0.5 -> 67.0, firefox-bin: 66.0.5 -> 67.0 [19.03] firefox 66.0.5 -> 67.0, firefox-bin: 66.0.5 -> 67.0, firefox-esr-60: 60.6.3esr -> 60.7.0esr May 21, 2019
@andir
Copy link
Member Author

andir commented May 21, 2019

Due to the rebuild amount merged into staging-19.03 in 3fab4f7. If the changelog (especially the security related changes) ever get published/updated by Mozilla we can still revisit merging this into the release branch.

@andir andir closed this May 21, 2019
@jonringer
Copy link
Contributor

I ran nix-shell -p nix-review --run "nix-review wip" overnight and it stalled with
[1/2390/2394 built (70 failed), 6071 copied (2 failed) (27270.7/27294.1 MiB), 7810.1 MiB DL]

the last error message was

/nix/store/2dfjlvp38xzkyylwpavnh61azi0d168b-binutils-2.31.1/bin/ld: cannot open output file /build/CNTK/build/lib/Cntk.ImageWriter-2.4.so: No such file or directory
  collect2: error: ld returned 1 exit status
  make[1]: *** [Makefile:1045: /build/CNTK/build/lib/Cntk.ImageWriter-2.4.so] Error 1
  rm Source/CNTKv2LibraryDll/proto/CNTK.pb.cc Source/CNTKv2LibraryDll/tensorboard/tensorboard.pb.cc Source/CNTKv2LibraryDll/proto/onnx/protobuf/onnx-ml.pb.cc
  make[1]: Leaving directory '/build/CNTK'
  make: *** [Makefile:6: all] Error 2
cannot build derivation '/nix/store/6c4gw4irnnjnzzn6yy2dhd7lvwn5d9ym-python2.7-CNTK-2.4.drv': 1 dependencies couldn't be built

@andir
Copy link
Member Author

andir commented May 21, 2019

My experience with nix-review and rebuilds of this size isn't very positive. It works for a few packages but if ~20k packages are being touched it easily doesn't help you come to a good conclusion. nix-review (used to?) stop(s) at the first failure. There are a lot of broken packages in nixpkgs… :/

I started a release.nix build on my hydra yesterday: https://hydra.h4ck.space/eval/186 (ipv6 only). While it does only run the NixOS tests those give a nice overview of the state of breakage. There might be some breakage but we will only notice that if we try building all the things. Which the NixOS hydra (https://hydra.nixos.org/jobset/nixpkgs/staging-19.03) does right now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants