Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

solr: 8.0.0 -> 8.1.0 #61845

Merged
merged 2 commits into from May 22, 2019
Merged

solr: 8.0.0 -> 8.1.0 #61845

merged 2 commits into from May 22, 2019

Conversation

aanderse
Copy link
Member

Motivation for this change

version bump

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@aanderse
Copy link
Member Author

@GrahamcOfBorg test solr.solr_8

@ofborg ofborg bot requested review from domenkozar and rickynils May 22, 2019 00:55
mmahut
mmahut approved these changes May 22, 2019
View reviewed changes
Copy link
Member

@mmahut mmahut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • reviewed the diff and commit messages
  • made sure ofBorg build succeeded for all applicable platforms
  • run nix-review without any failure
  • tested the binary, the daemon is running fine

@c0bw3b c0bw3b changed the title solr: 0.8.0 -> 0.8.1 solr: 8.0.0 -> 8.1.0 May 22, 2019
@c0bw3b c0bw3b merged commit 5f944be into NixOS:master May 22, 2019
@aanderse aanderse deleted the solr branch May 22, 2019 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmahut mmahut mmahut approved these changes

@domenkozar domenkozar Awaiting requested review from domenkozar

@rickynils rickynils Awaiting requested review from rickynils

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@aanderse @mmahut @c0bw3b