Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pstree: re-init at 2.39 (reverts #60994) #61763

Merged
merged 2 commits into from May 20, 2019
Merged

pstree: re-init at 2.39 (reverts #60994) #61763

merged 2 commits into from May 20, 2019

Conversation

c0bw3b
Copy link
Contributor

@c0bw3b c0bw3b commented May 20, 2019

Motivation for this change

Closes #61725 and reverts #60994
pstree runs on all Unixes whereas psmisc is Linux-only (and BSD) but not Darwin-compatible

cc @lilyball @thefloweringash

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@c0bw3b
Revert "pstree: remove and alias to psmisc"
3a2ccb5 
This reverts commit 4f8bf68.

Reason: psmisc is Linux-platforms only
@c0bw3b
pstree: refresh sources
6c82bfb 
Previous first URL was gone ;
+ refactor
+ enhance meta (homepage, license, maintainer)
+ define priority wrt psmisc
@c0bw3b c0bw3b self-assigned this May 20, 2019
@c0bw3b c0bw3b changed the title Pkg/pstree classic pstree: re-init at 2.39 (reverts #60994) May 20, 2019
@deliciouslytyped
Copy link
Contributor

deliciouslytyped commented May 20, 2019 •
edited

Would it be reasonable to leave a note in the package acknowledging that it's abandonware but stating that we're keeping it around to support non-linux platforms?

@c0bw3b
Copy link
Contributor Author

c0bw3b commented May 20, 2019

Well the last source is from 2015 and the homepage is still around, so for now I guess it's "alive enough".
I also added myself as maintainer as to remind me to check on it later.

@c0bw3b c0bw3b merged commit 650a295 into NixOS:master May 20, 2019
@c0bw3b c0bw3b deleted the pkg/pstree-classic branch May 20, 2019 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@c0bw3b c0bw3b

Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

pstree is no longer supported on Darwin
2 participants
@c0bw3b @deliciouslytyped