Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bind: 9.12.4-P1 -> 9.14.2 #61619

Merged
merged 1 commit into from May 21, 2019
Merged

bind: 9.12.4-P1 -> 9.14.2 #61619

merged 1 commit into from May 21, 2019

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented May 17, 2019

Motivation for this change

9.12 is EOL as of May 2019.

9.14.2 release notes (which appear to extend those for 9.14.1):

https://ftp.isc.org/isc/bind9/9.14.2/RELEASE-NOTES-bind-9.14.2.html

Please check the security fixes and prioritize this as appropriate.

NixOS tests should be checked of course :).

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@dtzWill
bind: 9.12.4-P1 -> 9.14.2
ee4fc39 
9.12 is EOL as of May 2019.

9.14.2 release notes (which appear to extend those for 9.14.1):

https://ftp.isc.org/isc/bind9/9.14.2/RELEASE-NOTES-bind-9.14.2.html

Please check the security fixes and prioritize this as appropriate.
@ofborg ofborg bot requested a review from peti May 17, 2019 09:07
@infinisil
Copy link
Member

@GrahamcOfBorg test bind
@GrahamcOfBorg test acme
@GrahamcOfBorg test nsd
@GrahamcOfBorg bind
@GrahamcOfBorg dnsperf
@GrahamcOfBorg nmapsi4
@GrahamcOfBorg sssd
@GrahamcOfBorg testssl
@GrahamcOfBorg twa

peti
peti approved these changes May 17, 2019
View reviewed changes
Copy link
Member

@peti peti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@dtzWill dtzWill merged commit 26026c3 into NixOS:staging May 21, 2019
@dtzWill dtzWill deleted the update/bind-9.14 branch May 21, 2019 08:02
@vcunat
Copy link
Member

vcunat commented Jun 9, 2019

This is in nixos-unstable now. The darwin problem from this PR was trivial to fix in #62882, but the test is broken, most likely due to this PR as well. Any idea what's wrong?

@m1cr0man
Copy link
Contributor

Encountered the issue of bind.service not starting today. Nothing helpful from systemd logs, as the command to generate the rndc.key is piped to /dev/null on stderr.

Removing that, I saw the following error:

# /nix/store/hjz9av8c209pm0nirbim1ylpjfpmdyjl-bind-9.14.2/sbin/rndc-confgen -r /dev/urandom -c /etc/bind/rndc.key -u named -a -A hmac
rndc-confgen: The -r option has been deprecated.

Removing the -r flag fixes the command, as the deprecation is hard. I will rebuild and test, and push a PR if it all goes well.

m1cr0man added a commit to m1cr0man/nixpkgs that referenced this pull request Jun 10, 2019
@m1cr0man
bind: Remove deprecated flag from rndc-confgen
a77d2d6 
Fixes bind.service startup issue after NixOS#61619
@m1cr0man m1cr0man mentioned this pull request Jun 10, 2019
Closed
10 tasks
saschagrunert pushed a commit to saschagrunert/nixpkgs that referenced this pull request Jun 11, 2019
@m1cr0man @vcunat
bind: Remove deprecated flag from rndc-confgen
24e974b 
Fixes bind.service startup issue after NixOS#61619
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peti peti peti approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@dtzWill @infinisil @vcunat @m1cr0man @peti