Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

matrix-synapse: 0.99.4 -> 0.99.5 #61899

Merged
merged 1 commit into from May 22, 2019
Merged

matrix-synapse: 0.99.4 -> 0.99.5 #61899

merged 1 commit into from May 22, 2019

Conversation

mguentner
Copy link
Contributor

Motivation for this change

https://github.com/matrix-org/synapse/releases/tag/v0.99.5

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Relevant discussion of previous update/PR: #61721

@ofborg ofborg bot requested a review from Ekleog May 22, 2019 17:26
@Ekleog
Copy link
Member

Ekleog commented May 22, 2019

@mguentner Do you have ofborg access? if not, I think you should ask for it with a PR like NixOS/ofborg#361 ; which will allow you to add a line like @ofborg build nixosTests.matrix-synapse in your PR text, making @ofborg build the test on more infrastructures than you likely can test locally :)

@ofborg build nixosTests.matrix-synapse

@fpletz
Copy link
Member

fpletz commented May 22, 2019

@GrahamcOfBorg test matrix-synapse

@Ekleog
Copy link
Member

Ekleog commented May 22, 2019

@fpletz github notifications are currently paused: https://www.githubstatus.com

@Ekleog Ekleog merged commit 608aee3 into NixOS:master May 22, 2019
@Ralith
Copy link
Contributor

Ralith commented May 25, 2019

Should this be backported to stable? It contains the implementation of rooms v4, which according to upstream will be needed for compatibility with rooms created post-1.0.

@Ekleog
Copy link
Member

Ekleog commented May 26, 2019

Indeed -- backported in 3769819

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ekleog Ekleog Awaiting requested review from Ekleog

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mguentner @Ekleog @fpletz @Ralith