Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

haskellPackages.hakyll: remove obsolete patch #61875

Merged
merged 1 commit into from May 22, 2019
Merged

haskellPackages.hakyll: remove obsolete patch #61875

merged 1 commit into from May 22, 2019

Conversation

endgame
Copy link
Contributor

@endgame endgame commented May 22, 2019

Motivation for this change

I want to use hakyll, it's marked as broken, but the problem seems to be an obsolete patch breaking the build.

Things done

I have also tested this by using the de-patched hakyll to rebuild my static website. It's fine.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@endgame endgame requested a review from basvandijk as a code owner May 22, 2019 11:04
@erictapen
Copy link
Member

Jupp, see also #61593.

@endgame endgame changed the base branch from master to haskell-updates May 22, 2019 20:57
@endgame endgame mentioned this pull request May 22, 2019
Closed
10 tasks
@infinisil
Copy link
Member

Ah I was just trying to fix up the other PR, but now I'm noticing you have the right changes here already. I'll merge this in a bit.

@infinisil infinisil merged commit 2956ca0 into NixOS:haskell-updates May 22, 2019
@endgame endgame deleted the unbork-hakyll branch May 22, 2019 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@basvandijk basvandijk Awaiting requested review from basvandijk

Assignees
No one assigned
Labels
6.topic: haskell 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@endgame @erictapen @infinisil