Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

katex: init at 0.10.2 #61873

Closed
wants to merge 1 commit into from
Closed

katex: init at 0.10.2 #61873

wants to merge 1 commit into from

Conversation

mt-caret
Copy link
Contributor

Motivation for this change

Add katex, a program that accepts a subset of TeX math and converts it to HTML.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@alexarice
Copy link
Contributor

nodePackages_10_x version works fine though there is no attribute for the nodePackages_8_x package (I'm assuming there should be one as a load of node v8 files have changed). I don't really know enough about js to review properly and I don't know how hard this would be to merge at this point

@veprbl
Copy link
Member

veprbl commented May 15, 2020

@mt-caret Do you still need katex to be included in nixpkgs?

@prusnak
Copy link
Member

prusnak commented May 30, 2020

Please rework your PR. It now has a merge conflict after PR #89184 has been merged

@mt-caret
Copy link
Contributor Author

@veprbl @prusnak Apologies for the late response. I'm no longer super interested in including this in nixpkgs, so I'm closing this PR.

@mt-caret mt-caret closed this May 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
2.status: merge conflict 6.topic: nodejs 10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@mt-caret @alexarice @veprbl @prusnak @ryantm