Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: NixOS/nix
base: cdcdf3e79837
Choose a base ref
...
head repository: NixOS/nix
compare: 4d829916e7c8
Choose a head ref
  • 2 commits
  • 1 file changed
  • 2 contributors

Commits on May 11, 2019

  1. progress-bar: hide expected if expected is 0 (unknown)

    Sometimes, "expected" can be "0", but in fact means "unknown".
    
    This is for example the case when downloading a file while the http
    server doesn't send the `Content-Length` header, like when running `nix
    build` pointing to a nixpkgs checkout streamed from GitHub:
    
    ⇒  nix build -f https://github.com/NixOS/nixpkgs/archive/master.tar.gz hello
    [1.8/0.0 MiB DL] downloading 'https://github.com/NixOS/nixpkgs/archive/master.tar.gz'
    
    In that case, don't show that weird progress bar, but only the (slowly
    increasing) downloaded size ("done").
    
    ⇒  nix build -f https://github.com/NixOS/nixpkgs/archive/master.tar.gz hello
    [1.8 MiB DL] downloading 'https://github.com/NixOS/nixpkgs/archive/master.tar.gz'
    
    This commit also updates fmt calls with three numbers (when something is
    currently 'running' too) - I'm not sure if this can be provoked, but
    showing "0" as expected doesn't make any sense, as we're obviously doing
    more than nothing.
    flokli committed May 11, 2019
    Copy the full SHA
    6ade7ec View commit details
    Browse the repository at this point in the history

Commits on May 21, 2019

  1. Merge pull request #2800 from flokli/progress-bar-hide-unknown-expected

    progress-bar: hide expected if expected is 0 (unknown)
    edolstra committed May 21, 2019
    Copy the full SHA
    4d82991 View commit details
    Browse the repository at this point in the history