Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tengine: 2.2.3 -> 2.3.0 #61907

Merged
merged 1 commit into from May 26, 2019
Merged

tengine: 2.2.3 -> 2.3.0 #61907

merged 1 commit into from May 26, 2019

Conversation

Izorkin
Copy link
Contributor

@Izorkin Izorkin commented May 22, 2019 •
edited

Motivation for this change

Update tengine to v2.3.0

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Izorkin
Copy link
Contributor Author

Izorkin commented May 22, 2019

@GrahamcOfBorg build tengine

@Izorkin
Copy link
Contributor Author

Izorkin commented May 22, 2019

Please help to fix build this package with sanbox mode.

@Izorkin Izorkin mentioned this pull request May 22, 2019
Merged
10 tasks
@Mic92
Copy link
Member

Mic92 commented May 25, 2019

The buildsystem checks if /etc/resolve.conf exists.
It could be patched to skip this check to make the build work:

https://github.com/alibaba/tengine/blob/master/auto/unix#L1075

@Izorkin
Copy link
Contributor Author

Izorkin commented May 26, 2019

@Mic92 thanks, update.

@Izorkin
Copy link
Contributor Author

Izorkin commented May 26, 2019

@GrahamcOfBorg build tengine

@Izorkin
Copy link
Contributor Author

Izorkin commented May 26, 2019

thanks, update

@c0bw3b
Copy link
Contributor

c0bw3b commented May 26, 2019

Result of nix-review pr 61907 on NixOS

1 package were build:
  • tengine

@c0bw3b c0bw3b merged commit f43b54f into NixOS:master May 26, 2019
@Izorkin Izorkin deleted the tengine branch May 27, 2019 04:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@c0bw3b c0bw3b c0bw3b left review comments

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Izorkin @Mic92 @c0bw3b