Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[19.03] signal-desktop: 1.22.0 -> 1.24.1 #61889

Closed
wants to merge 1 commit into from
Closed

[19.03] signal-desktop: 1.22.0 -> 1.24.1 #61889

wants to merge 1 commit into from

Conversation

asymmetric
Copy link
Contributor

@asymmetric asymmetric commented May 22, 2019 •
edited

Motivation for this change

Backport from master.

The current version in 19.03 has expired, meaning no messages can be sent.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@flokli
Copy link
Contributor

flokli commented May 22, 2019

dup of #61886.

@flokli flokli closed this May 22, 2019
@asymmetric asymmetric deleted the signal branch May 22, 2019 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@asymmetric @flokli