memtest86-efi: backport to 19.03 #61806
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been mentioned on Nix community. There might be relevant details there: https://discourse.nixos.org/t/prs-ready-for-review-may-2019/3032/11 |
|
Any reason for 20e0daa13574aaa55841d778bf5fbdfd3f8d6432 not cherry-picking -x ecb90ae? |
samueldr
approved these changes
Jul 27, 2019
There was a problem hiding this comment.
Approving, though would be interested in knowing the answer of the question in my (just added) previous comment before merging. Though it looks good enough, and is a useful backport.
The libguestfs backport is non-intrusive, and the memtest86 backport isn't either. In the end a net positive for end-users that may need to test their memory.
Appliances are necessary when building images using virt-builder. (e.g. `virt-builder -o debian-9.img debian-9`) Signed-off-by: Roosembert Palacios <roosembert.palacios@epfl.ch> (cherry picked from commit ecb90ae)
This creates a new package, memtest86-efi. This is a recent version of the unfree version of memtest86. There appear to be no restrictions on the use or redistribution of this. Backport from NixOS#60967. (cherry picked from commit d273bf5) (cherry picked from commit e01e13a) (cherry picked from commit 439a755) (cherry picked from commit 4abafaf)
….03) This commit adds support for installing the memtest86 EFI app and adding a boot entry for it with systemd-boot. Backported from NixOS#61036. (cherry picked from commit b12ea62) (cherry picked from commit d88d675)
cdepillabout
force-pushed
the
backport-memtest86
branch
from
7718248
to
3c21a29
Compare
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR backports the following PRs to 19.03:
These PRs do two big things:
systemd-bootmenu.Motivation for this change
The above PRs have all been merged into
master. I wanted this functionality available in 19.03 as well.You can try building the memtest86-efi command with the following, as long as you have this PR checked out:
$ nix-build -A memtest86-efiYou can test installing the memtest86 EFI app with the following nixos setting:
Although you need to be using
systemd-bootfor this to work.Also, you need
allowUnfreeset totruefor both of these to work.Pinging @c0bw3b and @JohnAZoidberg since they were nice enough to do reviews for the above PRs. Also pinging @Lassulus and @matthewbauer since they merged in the above PRs.
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)