Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

indent: 2.2.10 -> 2.2.12 #61808

Merged
merged 2 commits into from May 21, 2019
Merged

indent: 2.2.10 -> 2.2.12 #61808

merged 2 commits into from May 21, 2019

Conversation

mmahut
Copy link
Member

@mmahut mmahut commented May 21, 2019 •
edited

Motivation for this change

Update to the latest version which fixes issue #61768.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@mmahut mmahut changed the title indent: 2.2.10 -> 2.2.12 [WIP] indent: 2.2.10 -> 2.2.12 May 21, 2019
@mmahut mmahut changed the title [WIP] indent: 2.2.10 -> 2.2.12 indent: 2.2.10 -> 2.2.12 May 21, 2019
tomberek
tomberek approved these changes May 21, 2019
View reviewed changes
Copy link
Contributor

@tomberek tomberek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Builds, runs, functions on Ubuntu. Reverse dependencies function (lush2 tested)

@grahamc
Copy link
Member

grahamc commented May 21, 2019

@GrahamcOfBorg build lush2
@GrahamcOfBorg build indent

grahamc
grahamc requested changes May 21, 2019
View reviewed changes
Copy link
Member

@grahamc grahamc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this doesn't build on Darwin for some reason: https://logs.nix.ci/?key=nixos/nixpkgs.61808&attempt_id=f4f37ee3-367c-4f22-b0e7-5b3e09114e24 That is a blocker, as it is in such a large number of closures.

@grahamc
Copy link
Member

grahamc commented May 21, 2019

cc @LnL7 do you have insight in to what is going on with this failure?

@mmahut
Copy link
Member Author

mmahut commented May 21, 2019

cc @acowley as he has fixed something similar for indent in the past

@LnL7
Copy link
Member

LnL7 commented May 21, 2019

Looks like something glibc specific was added, 7790868 should do the trick.

@LnL7
Copy link
Member

LnL7 commented May 21, 2019

@GrahamcOfBorg build lush2
@GrahamcOfBorg build indent

@matthewbauer matthewbauer merged commit 6bba257 into NixOS:master May 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grahamc grahamc grahamc requested changes

@tomberek tomberek tomberek approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 501+ 10.rebuild-darwin: 1001-2500 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@mmahut @grahamc @LnL7 @tomberek @matthewbauer