Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

spyder: 3.3.3 -> 3.3.4, convert to python modules #61812

Merged
merged 3 commits into from May 21, 2019
Merged

spyder: 3.3.3 -> 3.3.4, convert to python modules #61812

merged 3 commits into from May 21, 2019

Conversation

gebner
Copy link
Member

@gebner gebner commented May 21, 2019

Motivation for this change

I want to package CQ-editor, which has spyder as a dependency.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@gebner gebner requested a review from FRidh as a code owner May 21, 2019 16:13
@gebner
Copy link
Member Author

gebner commented May 21, 2019

@GrahamcOfBorg eval
@GrahamcOfBorg build spyder

@gebner
Copy link
Member Author

gebner commented May 21, 2019

@GrahamcOfBorg eval
@GrahamcOfBorg build spyder

@gebner gebner merged commit c9ff6f7 into NixOS:master May 21, 2019
@marcus7070 marcus7070 mentioned this pull request Aug 3, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@gebner