Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

llvmPackages_7.compiler-rt: fix typo #60067

Merged
merged 1 commit into from Apr 23, 2019

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Apr 23, 2019

Motivation for this change

Spotted while updating, although it looks familiar...
(was this fixed in llvm8 expression but not here, maybe?)

Anyway, I'm not sure immediately how to best test this--
since builds like
pkgsCross.aarch64-multiplatform.llvmPackages_7.compiler-rt
encounter errors in the build before getting to this part...

(it probably is best-tested with llvm-based toolchains, yes? :))

Ah, here it is:

d453273

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Copy link
Member

@vcunat vcunat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see no use in "waiting".

@vcunat vcunat merged commit 640fd92 into NixOS:master Apr 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants