Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

plex: modernize package, support i686 #60070

Closed
wants to merge 1 commit into from
Closed

plex: modernize package, support i686 #60070

wants to merge 1 commit into from

Conversation

tadfisher
Copy link
Contributor

@tadfisher tadfisher commented Apr 23, 2019 •
edited

Motivation for this change

I've been running this modified package on my server for a while now, and have been meaning to clean it up and submit a PR.

Essentially, this replaces the manual patchelf calls with autoPatchelfHook. I did this because Plex would not start on my system since they've added some libraries over time, such as libboost, which weren't accounted for in the install script.

I also added passthru.updateScript which queries the same release manifest as the Plex downloads page and does some parsing with jq to fetch the latest version and URL. This happens to work for multiple platforms as well, so I threw i686-linux support in the package. In the future, it should be possible to support AArch64 and Darwin builds.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested review from thoughtpolice and LnL7 April 23, 2019 06:02
@edude03
Copy link
Contributor

edude03 commented Apr 23, 2019

This looks fantastic! Thanks @tadfisher

@andrew-d
Copy link
Contributor

andrew-d commented Apr 24, 2019 •
edited

See also #56565, which uses buildFHSUserEnv, since Plex downloads codec binaries at runtime which can't be patched at build time.

@tadfisher
Copy link
Contributor Author

@andrew-d Ah, that makes more sense than this. I'll go ahead and close this; hopefully your work is merged soon. I'd be happy to contribute the update script if that makes maintainership easier.

@tadfisher tadfisher closed this Apr 24, 2019
@andrew-d
Copy link
Contributor

@tadfisher - Yeah, now that #56565 is merged, if you want to open a PR that adds the update script I think that'd be pretty useful 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thoughtpolice thoughtpolice Awaiting requested review from thoughtpolice

@LnL7 LnL7 Awaiting requested review from LnL7

Assignees
No one assigned
Labels
8.has: clean-up 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tadfisher @edude03 @andrew-d